LWN.net Logo

[PATCH 0/4] workqueue_tracepoint: Add worklet tracepoints for worklet lifecycle tracing

From:  Zhaolei <zhaolei@cn.fujitsu.com>
To:  Ingo Molnar <mingo@elte.hu>
Subject:  [PATCH 0/4] workqueue_tracepoint: Add worklet tracepoints for worklet lifecycle tracing
Date:  Fri, 24 Apr 2009 19:42:19 +0800
Message-ID:  <49F1A59B.3080206@cn.fujitsu.com>
Cc:  KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Frederic Weisbecker <fweisbec@gmail.com>, Steven Rostedt <rostedt@goodmis.org>, Tom Zanussi <tzanussi@gmail.com>, linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>, Andrew Morton <akpm@linux-foundation.org>
Archive-link:  Article, Thread

Ingo Molnar wrote:
> ...
> Basically, i'd suggest the following complete set of events instead:
> 
>  TRACE_EVENT(workqueue_create
>  TRACE_EVENT(workqueue_flush              /* NEW */
>  TRACE_EVENT(workqueue_destroy
> 
>  TRACE_EVENT(worklet_enqueue              /* NEW */
>  TRACE_EVENT(worklet_enqueue_delayed      /* NEW */
> 
>  TRACE_EVENT(worklet_execute              /* instead of workqueue_execution */
>  TRACE_EVENT(worklet_complete             /* NEW */
> 
>  TRACE_EVENT(worklet_cancel               /* NEW */
> 
> This allows the understanding of the life cycle of a workqueue and 
> of worklets that enter that workqueue. Note the distinction between 
> workqueue and worklet (work) - that is essential.
> 
> The parameters of the events are obvious, with one detail: i'd 
> suggest a 'cpu' parameter to the enqueue events, to allow the 
> mapping of the _on(..cpu) variants too.
> 
> I would not bother with schedule_on_each_cpu() instrumentation - 
> it's rarely used.
> 
> 	Ingo
> 
Hello, Ingo

These patchs add tracepoints for per-worklet tracing.
Now we have enough tracepoints to start makeing trace_workqueue.c support
worklet time mesurement.

Thanks
Zhaolei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Copyright © 2009, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds