Stable kernel 2.6.27.5 [LWN.net]

Stable kernel 2.6.27.5

Posted Nov 9, 2008 17:11 UTC (Sun) by mb (subscriber, #50428)
In reply to: Stable kernel 2.6.27.5 by PaXTeam
Parent article: Stable kernel 2.6.27.5

> code that the accessed data is 8 bytes long (sizeof u64)

Cool, thanks. I didn't notice that by reading the patch only.

> then there's a smaller issue of two useless unsigned long casts that anyone who actually looked at the whole code should have spotted.

Yeah, these casts look rather fishy to me, too.
In the first check casts are used and in the second one casts are not used (or the other way around).

(Log in to post comments)

Stable kernel 2.6.27.5

Posted Nov 9, 2008 17:37 UTC (Sun) by PaXTeam (subscriber, #24616) [Link]

well, the pointer dereferences along with the proper type casts are right in the next line after the bounds checks (prudent reviewers would check the entire code to account for all dereferences, however).