|| ||Matt Mackall <mpm-AT-selenic.com>|
|| ||Jiri Kosina <jkosina-AT-suse.cz>|
|| ||Re: Bloatwatch 2.6.28-rc1: i8042 DMI lookup tables|
|| ||Fri, 24 Oct 2008 18:13:22 -0500|
|| ||Linux Kernel Mailing List <linux-kernel-AT-vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov-AT-gmail.com>,
David Woodhouse <dwmw2-AT-infradead.org>,
Ingo Molnar <mingo-AT-redhat.com>|
On Sat, 2008-10-25 at 00:15 +0200, Jiri Kosina wrote:
> On Fri, 24 Oct 2008, Matt Mackall wrote:
> > We've added 12k of new initdata to allnoconfig builds for i8042 DMI
> > lookup tables:
> > http://www.selenic.com/bloatwatch/?cmd=compare;v1=2.6.27;...
> > It looks like each table entry is > 320 bytes as we reserve four 80-byte
> > slots in each for DMI match strings.
> Umm, and what is the actual problem with that, really?
The actual problem is that if the kernel grows by 12k every time a
developer says "what's the big deal?" the kernel will become very large
> OK, we can remove it from .init, but then it will be rotting in memory
> forever, which is quite sub-optimal, when this kind of DMI information is
> needed only during initialization.
I wasn't complaining that they were in init, but rather that they were
12k. For something like 37 entries. The entry size is ridiculous and
looks to have grown by a factor of 10 since 2.6.27. What, as they say,
is up with that?
It looks like David Woodhouse is to blame:
Automatic MODULE_ALIAS() for DMI match tables.
This is probably also responsible for most of the growth in x86 I
mentioned elsewhere, so it's about 25-30k damage in total. David?
Mathematics is the supreme nostalgia of our time.
to post comments)