LWN.net Logo

Re: [PATCH 4/5] select: make select() use schedule_hrtimeout()

From:  Alan Cox <alan-AT-lxorguk.ukuu.org.uk>
To:  Linus Torvalds <torvalds-AT-linux-foundation.org>
Subject:  Re: [PATCH 4/5] select: make select() use schedule_hrtimeout()
Date:  Fri, 29 Aug 2008 17:11:08 +0100
Message-ID:  <20080829171108.63e6dcd4@lxorguk.ukuu.org.uk>
Cc:  Arjan van de Ven <arjan-AT-infradead.org>, linux-kernel-AT-vger.kernel.org, mingo-AT-elte.hu, tglx-AT-tglx.de
Archive-link:  Article, Thread

> "schedule_timeout()", there's a big difference between asking for two 
> ticks and asking for two seconds. The latter should probably try to round 
> to a nice timer tick basis for power reasons).

I disagree - that is fixing the problem in the wrong place. The timer
structure needs an accuracy field of some form that the existing timer
functions initialise to 0.

On a heavily loaded system with things like network events the behaviour
of the overall system is too complex to do the job well except at the
timer level which seems all. At the virtualisation level the hypervisor
needs to be doing the work to merge timer events between guests for power
management.

Once the timers have an accuracy representation there doesn't need to be
any real difference anywhere in the stack.

Alan


(Log in to post comments)

Copyright © 2008, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds