Ok, so now that I've insulted you and your pets (they're ugly!),
show me wrong, and then call me a d*ckhead. ("Linus - you're a
d*ckhead, and you didn't understand the problem, so you're a
_stupid_ d*ckhead. And my pet may be ugly, but yours _smells_
Or say "Uh, yeah, we're morons, and here's the much better patch, and we
won't do that again".
-- Linus Torvalds
Amazing! Your code, once plugged into the kernel proper, booted
fine on 5 different x86 testsystems, it booted fine an allyesconfig
kernel with MAXSMP and NR_CPUS=4096, it booted fine on allnoconfig
as well (and allmodconfig and on a good number of randconfigs as
[B]ecause v1 of your code was so frustratingly and mind-blowingly
stable in testing (breaking a long track record of v1 patches in
this area of kernel), and because the perfect patch does not exist
by definition, i thought i'd mention that after a long search i
found and fixed a serious showstopper bug in your code: you used
"1ul" in your macros, instead of the more proper "1UL" style. The
ratio between the use of 1ul versus 1UL is 1:30 in the tree, so
your choice of integer literals type suffix capitalization was
deemed un-Linuxish, and was fixed up for good.
-- Ingo Molnar
In anycase, it sounds like Tux3 is using many similar ideas. I
think you are on the right track. I will add one big note of
caution, drawing from my experience implementing HAMMER, because I
think you are going to hit a lot of the same issues.
I spent 9 months designing HAMMER and 9 months implementing it.
During the course of implementing it I wound up throwing away
probably 80% of the original design outright.
-- Matthew Dillon
. The whole
is an interesting read in filesystem design.
The pure size of the -rc's _is_ making me a bit nervous,
though. Sure, it means that we are good at merging it all, but I
have to say that I sometimes wonder if we don't merge too much in
one go, and even our current (fairly short) release cycle is
actually too big.
Anyway, that's a discussion for some other event.
-- Linus Torvalds
I seem to be hearing a lot of silence over support for SSD devices.
I have this vague worry that there will be a large rollout of SSD
hardware and Linux will be found to have pants-around-ankles.
-- Andrew Morton
to post comments)