Re: BUG: unable to handle kernel NULL pointer dereference at 000000000000000e (reset_prng

From:		Herbert Xu <herbert-AT-gondor.apana.org.au>
To:		Andrew Morton <akpm-AT-linux-foundation.org>
Subject:		Re: BUG: unable to handle kernel NULL pointer dereference at 000000000000000e (reset_prng_context)
Date:		Wed, 16 Jul 2008 12:07:01 +0800
Message-ID:		<20080716040701.GA12570@gondor.apana.org.au>
Cc:		Alexey Dobriyan <adobriyan-AT-gmail.com>, davem-AT-davemloft.net, mingo-AT-elte.hu, nhorman-AT-tuxdriver.com, simon-AT-fire.lp0.eu, linux-kernel-AT-vger.kernel.org
Archive-link:		Article, Thread

On Tue, Jul 15, 2008 at 03:11:10PM -0700, Andrew Morton wrote:
>
> Except that such a high density of coding-style errors is an indication
> that the code was not closely and critically reviewed by an experienced
> kernel developer.
> 
> > Every damn single warning in this case is about whitespace or 80 column limit.
> > 
> > Every damn single one!

Indeed, I apologise for reviewing the code on a monitor that is wider
than yours.  If only we could make sure that all Linux developers
used smaller monitors then the code quality would surely improve!

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

(Log in to post comments)

Re: BUG: unable to handle kernel NULL pointer dereference at 000000000000000e (reset_prng_context)