The problem with leaving everything tweakable is that you're asking
users to make choices about things but not giving them the
information they need to make those choices. Whether you get a
power saving from hard drive spindown depends on whether the drive
is idle for long enough to save the power you'll spend spinning it
back up. Get it wrong and you'll be putting your drive under extra
load, reducing performance and consuming more power than you were
to begin with.
-- Matthew Garrett
If somebody wants to play with it, go wild. I didn't do
"change_bit()", because nobody sane uses that thing anyway. I
guarantee nothing. And if it breaks, nobody saw me do anything.
You can't prove this email wasn't sent by somebody who is good at
-- Linus Torvalds
Look at it this way: there is no way in which the reviewer of this
patch (ie: me) can work out why this function exists. Hence there
will be no way in which future readers of this code will be able to
work out why this function exists either. This is bad. These
things should be described in code comments and in the changelog
(whichever is most appropriate).
-- Andrew Morton
to post comments)