| From: |
| Abhishek Sagar <sagar.abhishek@gmail.com> |
| To: |
| rostedt@goodmis.org, Ingo Molnar <mingo@elte.hu> |
| Subject: |
| [PATCH 0/3][RFC] ftrace: track dynamic ftrace update failures |
| Date: |
| Sun, 01 Jun 2008 21:47:19 +0530 |
| Message-ID: |
| <4842CB8F.2000702@gmail.com> |
| Cc: |
| Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org> |
| Archive-link: |
| Article,
Thread
|
Hi Steven/Ingo,
In dynamic ftrace any record which fails gets freed to be recycled. This
happens normally during (although not limited to) tracing of init functions.
In general, failures can happen due to multiple reason, such as external
patching of kernel functions, instrumentation of the mcount calls-sites,
hardware error etc. As an example, in the case of kprobes if a probe is
installed on the mcount call site (before being converted to NOP or after) then
eventually ftrace will detect it and free the corresponding record. Kprobes
however will keep on single-sepping the instruction it installed the probe on.
These patches prevent freeing of records which have failed (except for init
functions). This prevents re-recording of failed functions and allows tracking
them so that they can be listed using a new debugfs file -> 'failures'. The
main change here is preventing removal of ftrace records from ftace_hash. This
way records can be looked up by their 'ip' at any time.
--
Regards,
Abhishek Sagar