LWN.net Logo

Getting the right kind of contributions

Getting the right kind of contributions

Posted May 28, 2008 22:18 UTC (Wed) by nix (subscriber, #2304)
In reply to: Getting the right kind of contributions by sbergman27
Parent article: Getting the right kind of contributions

Coding style is one thing. *Alignment of parentheses* is another.

(And yes, when I'm maintaining other people's code I do realign them if 
they're misaligned and I'm working in that area: but submitting patches 
that do nothing else is barmy.)


(Log in to post comments)

Getting the right kind of contributions

Posted May 29, 2008 8:50 UTC (Thu) by Los__D (guest, #15263) [Link]

I do think that if one is already changing a line which is incorrectly laid out then there's no point in _leaving_ it incorrect. There's no downside to fixing it. That being said, it's often sorely tempting to go hunting down nearby sillinesses. I succumb to that temptation and usually won't complain when others do also, up to a point.

-- Andrew Morton (Shamelessly stolen from Kerneltrap's quotes)

Copyright © 2013, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds