Re: [PATCH] kill empty chardev open/release methods
[Posted May 20, 2008 by corbet]
| From: |
| Alan Cox <alan-AT-lxorguk.ukuu.org.uk> |
| To: |
| corbet-AT-lwn.net (Jonathan Corbet) |
| Subject: |
| Re: [PATCH] kill empty chardev open/release methods |
| Date: |
| Sun, 18 May 2008 20:58:23 +0100 |
| Message-ID: |
| <20080518205823.4a79aa0f@core> |
| Cc: |
| Jonathan Corbet <corbet-AT-lwn.net>,
Linus Torvalds <torvalds-AT-linux-foundation.org>,
Ingo Molnar <mingo-AT-elte.hu>,
Andrew Morton <akpm-AT-linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra-AT-chello.nl>,
Thomas Gleixner <tglx-AT-linutronix.de>,
Alexander Viro <viro-AT-ftp.linux.org.uk>,
linux-kernel-AT-vger.kernel.org |
| Archive-link: |
| Article,
Thread
|
> As it turns out, a misc driver will still be OK because the BKL has not
> (yet) been pushed past misc_open(). What this does mean, though, is
> that all of those empty and trivial open functions need to be
> revisited. I thought this looked too easy the first time through...
I think it would be best to make them lock/unlock kernel in the first
pass and then work through them. The BKL can be subtle and evil, but as I
brought it into the world I guess I must banish it ;)
Alan
(
Log in to post comments)
