| |||||||||||||
The last things through the 2.6.26 merge windowThe last things through the 2.6.26 merge windowPosted May 8, 2008 8:06 UTC (Thu) by cventers (subscriber, #31465)Parent article: The last things through the 2.6.26 merge window
bool sysfs_streq(const char *s1, const char *s2); Shouldn't such a generic function be named something like streqnl()?
(Log in to post comments)
The last things through the 2.6.26 merge window Posted May 8, 2008 9:25 UTC (Thu) by johill (subscriber, #25196) [Link] I'd think that the function isn't all that generic, when would you want to use it (outside of the sysfs braindamage)? Sure, its definition might sound generic, but I wouldn't think you should use it often anyway.
The last things through the 2.6.26 merge window Posted May 8, 2008 15:16 UTC (Thu) by jzbiciak (✭ supporter ✭, #5246) [Link] Hmm... It seems like removing optional trailing newlines early ought to be more general and robust. After all, perl has had chomp() for what, a decade or more?
The last things through the 2.6.26 merge window Posted May 8, 2008 16:37 UTC (Thu) by bronson (subscriber, #4806) [Link] As of this year, I think chop is 20 years old (+/- 1 year). So this is what the future looks like... not very impressive. I thought we'd all be using CORBA-connected dataflow languages by now!
The last things through the 2.6.26 merge window Posted May 8, 2008 16:47 UTC (Thu) by jzbiciak (✭ supporter ✭, #5246) [Link] Well, there's chop() and there's chomp(). Methinks chomp() is more appropriate to handle optional newlines. :-)
|
|||||||||||||