LWN.net Logo

Merge window opens, kgdb merged

Merge window opens, kgdb merged

Posted Apr 19, 2008 15:20 UTC (Sat) by muwlgr (guest, #35359)
Parent article: Merge window opens, kgdb merged

It seems that x86 tree gets bloated (look at 117->136 KLOC step).
Where are those famous code removers, so praised in LWN articles ?
Would be great if they get their hands at the issue ... :>


(Log in to post comments)

Merge window opens, kgdb merged

Posted Apr 19, 2008 15:36 UTC (Sat) by rvfh (subscriber, #31018) [Link]

My thought exactly: I was expecting the merge to _reduce_ the code by, say, 20-30%...

Any knowledgeable person care to explain?

Merge window opens, kgdb merged

Posted Apr 19, 2008 17:12 UTC (Sat) by mingo (subscriber, #31122) [Link]

the linecount jump in the code-quality table was because KVM was merged into the x86 tree
under arch/x86/kvm/ and the lguest code was merged under arch/x86/lguest.

also, we've got a new sub-architecture, more debug features such as kgdb, etc. etc. - each of
which is extra code.

Since v2.6.24-rc1 (which was the first big unification step with 600 unification patches)
there were more than 1600 commits in arch/x86/. Every time we reduce size with a unification
some new feature eats it up ;-)

All in one: life didnt stop with unification :-)

Merge window opens, kgdb merged

Posted Apr 19, 2008 19:58 UTC (Sat) by rvfh (subscriber, #31018) [Link]

Thanks a lot :)

Doesn't this mean that the error/kloc figure is a bit biased then? Although the conclusion
remains the same: it decreased.

Anyway, I do trust you clever people do the Right Thing, as the quality of my environment as a
whole clearly shows.

I just love Linux :)

Merge window opens, kgdb merged

Posted Apr 19, 2008 22:55 UTC (Sat) by adobriyan (guest, #30858) [Link]

> Doesn't this mean that the error/kloc figure is a bit biased then?

What errors are you talking about?

Nastygrams that even checkpatch.pl itself calls "WARNING"s?

Copyright © 2012, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds