Review pointer

Review pointer

Posted Jan 22, 2008 23:10 UTC (Tue) by Max.Hyre (subscriber, #1054)
In reply to: Making code reviews easier with Review Board by quotemstr
Parent article: Making code reviews easier with Review Board

Any suggestions on how to best go about code reviews when you have the luxury of everyone being in the same physical place?

Make sure everyone has already reviewed the code before the meeting. People should show up with their lists of comments, ready to start talking.

The alternative (everyone is reading the code for the first time) leaves people

• distracted from understanding one section of code by someone starting to discuss another,
• thinking a section is OK because it's been discussed by others,
      and, probably worst,
  
• unwilling to hold things up because they want to look more deeply into something that the rest are already finished with. It takes guts to say ``Wait a minute...'' when everyone else is ready to go on to the next page.

Such ``show and go'' reviews are much better than nothing, but it's a vast improvement if each reviewer has gone over the code before the get-together.

---

(Log in to post comments)