Re: [PATCH] x86_64: fix problems due to use of "outb" to port 80
on some AMD64x2 laptops, etc.
[Posted December 18, 2007 by corbet]
| From: |
| "H. Peter Anvin" <hpa-AT-zytor.com> |
| To: |
| Ingo Molnar <mingo-AT-elte.hu> |
| Subject: |
| Re: [PATCH] x86_64: fix problems due to use of "outb" to port 80
on some AMD64x2 laptops, etc. |
| Date: |
| Fri, 14 Dec 2007 10:02:57 -0800 |
| Message-ID: |
| <4762C551.5070003@zytor.com> |
| Cc: |
| "David P. Reed" <dpreed-AT-reed.com>,
Thomas Gleixner <tglx-AT-linutronix.de>,
linux-kernel-AT-vger.kernel.org, Ingo Molnar <mingo-AT-redhat.com>,
Rene Herman <rene.herman-AT-keyaccess.nl>,
Pavel Machek <pavel-AT-ucw.cz> |
| Archive-link: |
| Article,
Thread
|
Ingo Molnar wrote:
>
> wow, cool fix! (I remember that there were other systems as well that
> are affected by port 0x80 muckery - i thought we had removed port 0x80
> accesses long ago.)
>
> how about the simpler fix below, as a first-level approach? We can then
> remove the _p in/out sequences after this.
>
I believe this will suffer from the issue that was raised: this will use
udelay() long before loop calibration (and no, we can't just "be
conservative" since there is no "conservative" value we can use.)
Worse, I suspect that at least the PIT, which may need to be used for
udelay calibration, is one of the devices that may be affected. I have
seen the Verilog for a contemporary chipset, and it can only access the
PIT once per microsecond -- this actually has to do with the definition
of the PIT; some of the PIT operations are ill-defined if allowed at a
higher frequency than the PIT clock.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
(
Log in to post comments)