Re: [PATCH 1/16] CRIS architecture: Correct compile errors

On Tue, 30 Oct 2007 10:28:11 +0100
Jesper Nilsson <jesper.nilsson@axis.com> wrote:

> Remove include of asm/bitops.h, not needed here, corrects compilation error
> (__le64 undefined).
> 
> Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
> 
> ---
>  posix_types.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- clean_linux-2.6.23/include/asm-cris/posix_types.h	2007-10-09 22:31:38.000000000 +0200
> +++ linux-2.6.23/include/asm-cris/posix_types.h	2007-10-25 11:32:56.000000000 +0200
> @@ -52,7 +52,6 @@
>  } __kernel_fsid_t;
>  
>  #ifdef __KERNEL__
> -#include <asm/bitops.h>
>  
>  #undef	__FD_SET
>  #define __FD_SET(fd,fdsetp) set_bit(fd, (void *)(fdsetp))
> 

This doesn't apply and I'm not sure that it is still needed or correct.

I'll drop it.

Please always prepare and test patches against the latest kernel.  2.6.23
is very much _not_ the latest kernel - there is a 50MB diff between 2.6.23
and 2.6.24-rc1.  That's a lot of difference.