LWN.net Logo

Stringbuf, v2

From:  Matthew Wilcox <matthew@wil.cx>
To:  Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject:  Stringbuf, v2
Date:  Wed, 24 Oct 2007 13:58:47 -0600
Message-ID:  <20071024195847.GE27248@parisc-linux.org>
Archive-link:  Article, Thread


Incorporated all feedback received:

 - Explicitly allow people to dereference sb->buf and sb->len, and include
   comments about the potential problems with doing so.  Document that alloc
   is probably better left unreferenced.  Remove sb_len() and sb_string().
 - Ensure that we grow by at least 1.5x, even if we're using slob.
 - Start by allocating 128 bytes
 - Pass a gfp_t to sb_printk
 - Drop the bogus change to snd_ac97_proc_regs_write
 - Add stringbuf.o to obj-y instead of lib-y, otherwise a fully modular kernel
   might not pull in sb_printf

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

Copyright © 2007, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds