LWN.net Logo

Re: Fwd: struct inode size reduction.

From:  Alexander Viro <viro@math.psu.edu>
To:  Andries Brouwer <aebr@win.tue.nl>
Subject:  Re: Fwd: struct inode size reduction.
Date:  Sun, 9 Mar 2003 21:23:41 -0500
Cc:  Roman Zippel <zippel@linux-m68k.org>, Christoph Hellwig <hch@infradead.org>, Dave Jones <davej@codemonkey.org.uk>, Linux Kernel <linux-kernel@vger.kernel.org>

On Mon, Mar 10, 2003 at 12:08:24AM +0100, Andries Brouwer wrote:
> =====
> +int register_chrdev(unsigned int major, const char *name,
> +                   struct file_operations *fops)
> +{
> +       return register_chrdev_region(major, 0, 256, name, fops);
> +}

That's Wrong API(tm).  Why do you need to keep separation between
major and first minor?  Just pass dev_t start and unsigned len.

BTW, I'd like to take a look at your CIDR for chrdev - I've got one
to resurrect and it might make sense to compare-and-merge.  And
yes, I'm finally back - hopefully for good.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


(Log in to post comments)

Copyright © 2003, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds