|| ||Andrew Morton <akpm-AT-linux-foundation.org>|
|| ||"Ray Lee" <ray-lk-AT-madrabbit.org>|
|| ||Re: -mm merge plans for 2.6.23|
|| ||Mon, 23 Jul 2007 22:18:46 -0700|
|| ||Nick Piggin <nickpiggin-AT-yahoo.com.au>,
Jesper Juhl <jesper.juhl-AT-gmail.com>, linux-kernel-AT-vger.kernel.org,
ck list <ck-AT-vds.kolivas.org>, linux-mm-AT-kvack.org,
Paul Jackson <pj-AT-sgi.com>|
On Mon, 23 Jul 2007 21:53:38 -0700 "Ray Lee" <firstname.lastname@example.org> wrote:
> Since this merge period has appeared particularly frazzling for
> Andrew, I've been keeping silent and waiting for him to get to a point
> where there's a breather. I didn't feel it would be polite to request
> yet more work out of him while he had a mess on his hands.
Let it just be noted that Con is not the only one who has expended effort
on this patch. It's been in -mm for nearly two years and it has meant
ongoing effort for me and, to a lesser extent, other MM developers to keep
> But, given this has come to a head, I'm asking now.
> Andrew? You've always given the impression that you want this run more
> as an engineering effort than an artistic endeavour, so help us out
> here. What are your concerns with swap prefetch? What sort of
> comparative data would you like to see to justify its inclusion, or to
> prove that it's not needed?
Critera are different for each patch, but it usually comes down to a
cost/benefit judgement. Does the benefit of the patch exceed its
maintenance cost over the lifetime of the kernel (whatever that is).
In this case the answer to that has never been clear to me. The (much
older) fs-aio patches were (are) in a similar situation.
The other consideration here is, as Nick points out, are the problems which
people see this patch solving for them solveable in other, better ways?
IOW, is this patch fixing up preexisting deficiencies post-facto?
To attack the second question we could start out with bug reports: system A
with workload B produces result C. I think result C is wrong for <reasons>
and would prefer to see result D.
> Or are we reading too much into the fact that it isn't merged? In
> short, communicate please, it will help.
Well. The above, plus there's always a lot of stuff happening in MM land,
and I haven't seen much in the way of enthusiasm from the usual MM
to post comments)