Not logged in
Log in now
Create an account
Subscribe to LWN
LWN.net Weekly Edition for May 16, 2013
A look at the PyPy 2.0 release
PostgreSQL 9.3 beta: Federated databases and more
LWN.net Weekly Edition for May 9, 2013
(Nearly) full tickless operation in 3.10
Oh dear, that wouldn't work very well with me, or with anyone else who has a chronic inability to say no :/
Where have the reviewers gone?
Posted May 24, 2007 19:28 UTC (Thu) by smoogen (subscriber, #97)
Posted May 24, 2007 23:46 UTC (Thu) by giraffedata (subscriber, #1954)
And on the other hand, I would hate to have someone review my own code under that standard, because a reviewer can interpret it as meaning if my code isn't written the way he would do it, I can't ship it. I.e. I must function as some stranger's lackey.
A clear definition of the meaning of a review is essential to eliminating the arguments, frustrations, and hurt feelings that turn people off of both sides of reviewing (don't want to review; don't want to submit code for review). And yet, I almost never see it. And, strangely, most people don't seem to notice it missing.
There is quite a variety of activity that can be a review.
One kind of a review is simply advice. You're pointing out to the coder things he may have missed. You've satisfied your obligation if you've taken a reasonable look at the code and communicated every issue that you think he may have overlooked. The code is the responsibility of the coder.
On the other end of the scale is acceptance of the code. The reviewer owns it and has full responsibility for it. He can reject it for any reason without even stating a reason -- correctness, readability, indentation, uselessness. He can also accept it without reading it.
My point is that if the coder and reviewer are working off different definitions, the review is likely to be unpleasant for both and I could see how people wouldn't volunteer to review code.
Copyright © 2013, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds