Where have the reviewers gone?
Posted May 24, 2007 9:33 UTC (Thu) by MathFox
In reply to: Where have the reviewers gone?
Parent article: Where have the reviewers gone?
It very much depends on the review-instructions. I have done code reviews on various (proprietary) projects and on one project we had an pretty simple and effective review guideline:
Would you accept the responsibility to maintain (fix bugs) in the code?
The goal wan not to get 100% bug free code, but to get clean and fixable code. (If we saw flaws, we pointed them out; most of them were then quickly fixed.) I can imagine that PostgreSQL places the bar a little higher and looks for data integrity and security issues too.
Anyway, it is reasonable to expect a peer review to take 5-10% of the coding time; when you need more, the code has become too complex and is ripe for a (re)design.
to post comments)