LWN.net Logo

Quote of the week

But being a subsystem maintainer requires that you trust contributors to some degree, and you just can't trust contributors when you're a perfectionist. This means that the maintainer should be less of a perfectionist than the contributors, otherwise he/she ends up doing everything by him/herself.
-- Jean Delvare
(Log in to post comments)

Quote of the week

Posted Apr 12, 2007 16:15 UTC (Thu) by i3839 (guest, #31386) [Link]

Another good quote is from Rusty Russell:
> Uhm, I am bit confused now. Why don't you just use end_request() here?

What a question!  end_request() doesn't end a request!  What a crazy
idea!

As far as I can tell, every name in the block layer is actually some
variant of "fuck off, this is too complicated for you to understand".

Hope that clarifies!
Rusty.

Quote of the week

Posted Apr 13, 2007 1:14 UTC (Fri) by jzbiciak (✭ supporter ✭, #5246) [Link]

*chuckle*

So what, pray tell, does end_request do?!?

Quote of the week

Posted Apr 13, 2007 18:07 UTC (Fri) by i3839 (guest, #31386) [Link]

It's a bit of a mystery, really. It surely seems to try to end something.
void end_request(struct request *req, int uptodate)
{
	if (!end_that_request_first(req, uptodate, req->hard_cur_sectors)) {
		add_disk_randomness(req->rq_disk);
		blkdev_dequeue_request(req);
		end_that_request_last(req, uptodate);
	}
}

Copyright © 2007, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds