LWN.net Logo

Re: [ck] Re: Swap prefetch merge plans

From:  Andrew Morton <akpm-AT-linux-foundation.org>
To:  jos poortvliet <jos-AT-mijnkamer.nl>
Subject:  Re: [ck] Re: Swap prefetch merge plans
Date:  Fri, 9 Feb 2007 12:30:29 -0800
Cc:  ck-AT-vds.kolivas.org, Con Kolivas <kernel-AT-kolivas.org>, linux-kernel-AT-vger.kernel.org
Archive-link:  Article, Thread

On Fri, 09 Feb 2007 14:13:03 +0100
jos poortvliet <jos@mijnkamer.nl> wrote:

> Nick's comment, replying to me some time ago:

I think I was thinking of this:

	http://lkml.org/lkml/2006/2/6/509

> Is there 
> something fundamentally wrong with the kernel-hackers-culture, or are these 
> incidents?

Well yes, there are incidents.  We have too many coders and not enough
reviewers, testers and bug-fixers.

If I had two solid days to sit down and carefully review, test,
try-to-exploit and if necessary improve/fix this code then perhaps we'd get
there.  But I'm nowhere vaguely near being able to afford that time and
things are just sitting there.


I have an email sitting in my drafts folder stating that I'll no longer
accept any features unless they've been publically reviewed in detail and
run-time tested by a third party.  The idea being to force people to spend
more time reviewing and testing each other's stuff and less time writing
new stuff.  Maybe on a sufficiently gloomy day I'll actually send it.



(Log in to post comments)

Re: [ck] Re: Swap prefetch merge plans

Posted Feb 17, 2007 21:00 UTC (Sat) by JohnNilsson (guest, #41242) [Link]

What about a review queue?

Put everything that has to get reviewed into a queue. The only way to get code into the kernel is to advance the queue, and the only way to do that is to review the code that's first in line.

Copyright © 2007, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds