LWN.net Logo

Advertisement

E-Commerce & credit card processing - the Open Source way!

Advertise here

Patch series to mark struct file_operations and struct inode_operations const

From:  Arjan van de Ven <arjan@infradead.org>
To:  linux-kernel@vger.kernel.org
Subject:  Patch series to mark struct file_operations and struct inode_operations const
Date:  Sat, 13 Jan 2007 16:51:08 -0800
Cc:  akpm@osdl.org
Archive-link:  Article, Thread

Hi,

today a sizable portion of the "struct file_operations" variables in the
kernel are const, but by far not all. Nor are any of the struct
inode_operations const. Marking these read-only datastructures const has
the advantage of reducing false sharing of these, often hot,
datastructures. In addition there have been cases where drivers or
filesystems accidentally and incorrectly wrote to such a struct
forgetting that it's a shared datastructure. By marking these const, the
compiler will warn/error on such instances.

The series is split up for size, there isn't really any logical order
for such a simple search-and-replace operation.

Greetings,
   Arjan van de Ven


Copyright © 2007, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds