Re: [GIT PATCH] More PCI patches for 2.6.13 [LWN.net]

From:		Linus Torvalds <torvalds-AT-osdl.org>
To:		Greg KH <gregkh-AT-suse.de>
Subject:		Re: [GIT PATCH] More PCI patches for 2.6.13
Date:		Fri, 9 Sep 2005 15:37:16 -0700 (PDT)
Cc:		Andrew Morton <akpm-AT-osdl.org>, linux-kernel-AT-vger.kernel.org, linux-pci-AT-atrey.karlin.mff.cuni.cz
Archive-link:		Article, Thread

On Fri, 9 Sep 2005, Greg KH wrote:
> 
> Dave Jones:
>   must_check attributes for PCI layer.

Why?

This only clutters up the compile, hiding real errors.

I think all those compile warnings are totally bogus. Who really cares? 
Are they going to be fixed, or were they added just to irritate people?

We should have a strict rule: anybody who adds things like "must_check"
and "deprecated" had better also be ready and willing to fix all the new
warnings they cause - you're not allowed to just assume that "somebody
else will fix it".

		Linus

(Log in to post comments)