LWN.net Logo

Fix printk format vs argument warning

From:  David Howells <dhowells@redhat.com>
To:  torvalds@osdl.org, akpm@osdl.org
Subject:  [PATCH] Fix printk format vs argument warning
Date:  Tue, 05 Jul 2005 21:03:39 +0100
Cc:  linux-kernel@vger.kernel.org
Archive-link:  Article, Thread


The attached patch makes the argument to this printk in
calibrate_migration_costs() always long to match the format string.

Signed-Off-By: David Howells <dhowells@redhat.com>
---
warthog>diffstat -p1 format-arg-size-2612mm1-10.diff 
 kernel/sched.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -uNrp linux-2.6.12-mm1/kernel/sched.c linux-2.6.12-mm1-cachefs-wander/kernel/sched.c
--- linux-2.6.12-mm1/kernel/sched.c	2005-06-22 13:54:08.000000000 +0100
+++ linux-2.6.12-mm1-cachefs-wander/kernel/sched.c	2005-06-22 14:10:57.000000000 +0100
@@ -5572,7 +5572,7 @@ void __devinit calibrate_migration_costs
 	printk("| migration cost matrix (max_cache_size: %d, cpu: %ld MHz):\n",
 			max_cache_size,
 #ifdef CONFIG_X86
-			cpu_khz/1000
+			cpu_khz/1000L
 #else
 			-1L
 #endif

Copyright © 2005, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds